-
Notifications
You must be signed in to change notification settings - Fork 790
Add device triggers for Paulmann 501.41 remote #4013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Fix quirk matching by using None for model/manufacturer to support devices reporting 'unk_model'. Migrated all device_automation_triggers from 'args' to 'params' to align with latest ZHA requirements. Also added comment at top.
41ddc27
to
4ca70fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4013 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 334 335 +1
Lines 10862 10869 +7
=======================================
+ Hits 9904 9911 +7
Misses 958 958 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaquirks/paulmann/sevenbtnremote.py
Outdated
""" | ||
|
||
signature = { | ||
"model": "unk_model", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change value to None, this value is to pass the tests here and on line 22
Thanks for the the automated tests! ✅ Important message: For the quirk to use change line 21 and 22
To
|
"unk_model" / "unk_manufacturer" generally means that the device didn't complete pairing properly. |
76d863c
to
b48d0f4
Compare
Updating Zigbee USB dongle fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a v2 quirk for defining the device_automation_triggers
instead.
See this example: https://github.com/zigpy/zha-device-handlers/blob/dev/zhaquirks/sonoff/button.py
Also, we already have some constants defined here: https://github.com/zigpy/zha-device-handlers/blob/dev/zhaquirks/const.py
Proposed change
Add a quirk for the Paulmann 501.41 Zigbee Smart Home Remote. This remote is available separate or included with various Paulmann Zigbee lighting kits. It does not report a model or manufacturer via the Basic cluster, so matching is done using endpoint and cluster signature. The quirk provides device automation triggers for:
Only meaningful, distinguishable button actions are included. Long press release events (e.g.,
stop_move_step
) are intentionally omitted due to lack of distinguishing data in the Zigbee payload.Checklist