Finish zig 0.15 port #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a breaking change for the C API that I am not sure is wanted, but it should be more than enough for a 0.15 port. Signed-off-by: Emily Flion <[email protected]>
|
This should now be reviewable. |
emneo-dev
added a commit
to liskvork/liskvork
that referenced
this pull request
Oct 20, 2025
Currently using a fork for the ini dep, which needs to be changed as soon as upstream is up to date. See: ziglibs/ini#17 Signed-off-by: Emily Flion <[email protected]>
emneo-dev
added a commit
to liskvork/liskvork
that referenced
this pull request
Oct 20, 2025
Currently using a fork for the ini dep, which needs to be changed as soon as upstream is up to date. See: ziglibs/ini#17 Signed-off-by: Emily Flion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just compiling and not crashing took about 2 hours total (the tests at least, the tests don't compile right now), now there is just an infinite loop to fix, which I suspect comes from the error handling of the
streamDelimiterLimit, as I am pretty sure I have not understood how it works...Why there are so many new variables in that PR: ziglang/zig#25033
I'm not a big fan of it, but the whole new Reader/Writer interfaces use
@fieldParentPtrextensively, so I have to.All commits in this PR will get squashed once ready to be reviewed.