chore(std.mem): Rename trimLeft and trimRight to trimStart and trimEnd#23700
Merged
alexrp merged 2 commits intoziglang:masterfrom May 12, 2025
Merged
chore(std.mem): Rename trimLeft and trimRight to trimStart and trimEnd#23700alexrp merged 2 commits intoziglang:masterfrom
trimLeft and trimRight to trimStart and trimEnd#23700alexrp merged 2 commits intoziglang:masterfrom
Conversation
Rename `trimLeft` to `trimStart`, and `trimRight` to `trimEnd`. `trimLeft` and `trimRight` functions remain as deprecated aliases for these new names.
sorairolake
force-pushed
the
rename-trims
branch
from
976291f to
5fc4448
Compare
linusg
reviewed
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
trimLefttotrimStart, andtrimRighttotrimEnd.trimLeftandtrimRightfunctions remain as deprecated aliases for these new names.Due to this change, these functions will do exactly what their names suggest in right-to-left scripts, just like in left-to-right scripts and non-string slices.
The new function names I suggested are inspired by JavaScript,12 C#,34 and Rust.56
Closes #23664
Footnotes
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trimStart ↩
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trimEnd ↩
https://learn.microsoft.com/en-us/dotnet/api/system.string.trimstart ↩
https://learn.microsoft.com/en-us/dotnet/api/system.string.trimend ↩
https://doc.rust-lang.org/std/primitive.str.html#method.trim_start ↩
https://doc.rust-lang.org/std/primitive.str.html#method.trim_end ↩