std.tar: add strip components error to diagnostics #19615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohlem
reviewed
Apr 11, 2024
src/Package/Fetch.zig
Outdated
| @@ -1184,6 +1184,7 @@ fn unpackTarball(f: *Fetch, out_dir: fs.Dir, reader: anytype) RunError!UnpackRes | |||
| .unable_to_create_file => |i| res.unableToCreateFile(stripRoot(i.file_name, res.root_dir), i.code), | |||
| .unable_to_create_sym_link => |i| res.unableToCreateSymLink(stripRoot(i.file_name, res.root_dir), i.link_name, i.code), | |||
| .unsupported_file_type => |i| res.unsupportedFileType(stripRoot(i.file_name, res.root_dir), @intFromEnum(i.file_type)), | |||
| .components_outside_stripped_prefix => {}, // impossible with strip_components = 0 | |||
There was a problem hiding this comment.
If this cannot be reached (from how I understand the comment), it could/should be explicit unreachable, right?
There was a problem hiding this comment.
Right!
Was thinking about that but I somehow decide to go this way. But you are right we have keyword for marking unreachable code paths. Fixing it.
Thanks.
This was the only kind of error which was raised in pipeToFileSystem and not added to Diagnostics. Shell tar silently ignores paths which are stripped out when used with `--strip-components` switch. This enables that same behavior, errors will be collected in diagnostics but caller is free to ignore that type of diagnostics errors. Enables use case where caller knows structure of the tar file and want to extract only some deeply nested folders ignoring upper files/folders. Fixes: ziglang#17620 by giving caller options: - not provide diagnostic and get errors - provide diagnostics and analyze errors - provide diagnostics and ignore errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the only kind of error which was raised in pipeToFileSystem and not added to Diagnostics.
Shell tar silently ignores paths which are stripped out when used with
--strip-componentsswitch. This enables that same behavior, errors will be collected in diagnostics but caller is free to ignore that type of errors.Enables use case where caller knows structure of the tar file and want to extract only some deeply nested folders ignoring upper files/folders.
Fixes: #17620 by giving caller options: