Eliminate BoundFn type from the language
#13821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
force-pushed
the
eliminate-bound-fn
branch
2 times, most recently
from
37f2968 to
433c6f2
Compare
|
I hope you don't mind if I tag along with this branch, a commit that removes zstd compression from the wasm binary. Here's why:
|
andrewrk
force-pushed
the
eliminate-bound-fn
branch
from
433c6f2 to
bc639bd
Compare
zeroZshadow
reviewed
Dec 10, 2022
andrewrk
force-pushed
the
eliminate-bound-fn
branch
from
bc639bd to
e985205
Compare
This also no longer uses zstd compression on this file. The reasoning for this is: * It has been demonstrated that the release tarballs are actually smaller if zig1.wasm gets compressed along with the other files rather than separately compressed. * More importantly, leaving zig1.wasm uncompressed may result in a smaller git repository size, since the repository as a whole could have savings across the multiple versions of zig1.wasm, which would not be possible if each one was independently compressed. * When in doubt, do what is simpler, which is to not have this extra zstd mechanism. This will remove the only "vendored" code from our build process, which is a nice property to have. Co-authored-by: Andrew Kelley <[email protected]>
andrewrk
force-pushed
the
eliminate-bound-fn
branch
from
e985205 to
89d1ccc
Compare
This was referenced Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5102
Closes #5695
Closes #10477