feat: tests #39
Draft
feat: tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+105
to
+128
| function onCall( | ||
| MessageContext calldata context, | ||
| bytes calldata message | ||
| ) external payable onlyGateway returns (bytes4) { | ||
| if (context.sender != universal) revert Unauthorized(); | ||
|
|
||
| ( | ||
| address receiver, | ||
| uint256 tokenId, | ||
| string memory uri, | ||
| uint256 gasAmount, | ||
| address sender | ||
| ) = abi.decode(message, (address, uint256, string, uint256, address)); | ||
|
|
||
| _safeMint(receiver, tokenId); | ||
| _setTokenURI(tokenId, uri); | ||
| if (gasAmount > 0) { | ||
| if (sender == address(0)) revert InvalidAddress(); | ||
| (bool success, ) = payable(sender).call{value: gasAmount}(""); | ||
| if (!success) revert GasTokenTransferFailed(); | ||
| } | ||
| emit TokenTransferReceived(receiver, tokenId, uri); | ||
| return ""; | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Comment on lines
+66
to
+132
| function transferCrossChain( | ||
| uint256 tokenId, | ||
| address receiver, | ||
| address destination | ||
| ) public payable { | ||
| if (msg.value == 0) revert ZeroMsgValue(); | ||
| if (receiver == address(0)) revert InvalidAddress(); | ||
|
|
||
| string memory uri = tokenURI(tokenId); | ||
| _burn(tokenId); | ||
|
|
||
| emit TokenTransfer(receiver, destination, tokenId, uri); | ||
|
|
||
| (address gasZRC20, uint256 gasFee) = IZRC20(destination) | ||
| .withdrawGasFeeWithGasLimit(gasLimitAmount); | ||
| if (destination != gasZRC20) revert InvalidAddress(); | ||
|
|
||
| address WZETA = gateway.zetaToken(); | ||
| IWETH9(WZETA).deposit{value: msg.value}(); | ||
| if (!IWETH9(WZETA).approve(uniswapRouter, msg.value)) { | ||
| revert ApproveFailed(); | ||
| } | ||
|
|
||
| uint256 out = SwapHelperLib.swapTokensForExactTokens( | ||
| uniswapRouter, | ||
| WZETA, | ||
| gasFee, | ||
| gasZRC20, | ||
| msg.value | ||
| ); | ||
|
|
||
| uint256 remaining = msg.value - out; | ||
| if (remaining > 0) { | ||
| IWETH9(WZETA).withdraw(remaining); | ||
| (bool success, ) = msg.sender.call{value: remaining}(""); | ||
| if (!success) revert TransferFailed(); | ||
| } | ||
|
|
||
| bytes memory message = abi.encode( | ||
| receiver, | ||
| tokenId, | ||
| uri, | ||
| 0, | ||
| msg.sender | ||
| ); | ||
| CallOptions memory callOptions = CallOptions(gasLimitAmount, false); | ||
|
|
||
| RevertOptions memory revertOptions = RevertOptions( | ||
| address(this), | ||
| true, | ||
| address(0), | ||
| abi.encode(tokenId, uri, msg.sender), | ||
| gasLimitAmount | ||
| ); | ||
|
|
||
| if (!IZRC20(gasZRC20).approve(address(gateway), gasFee)) { | ||
| revert ApproveFailed(); | ||
| } | ||
|
|
||
| gateway.call( | ||
| abi.encodePacked(connected[destination]), | ||
| destination, | ||
| message, | ||
| callOptions, | ||
| revertOptions | ||
| ); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Comment on lines
+41
to
+52
| function __UniversalTokenCore_init( | ||
| address gatewayAddress, | ||
| address universalAddress, | ||
| uint256 gas | ||
| ) internal { | ||
| if (gatewayAddress == address(0)) revert InvalidAddress(); | ||
| if (universalAddress == address(0)) revert InvalidAddress(); | ||
| if (gas == 0) revert InvalidGasLimit(); | ||
| gateway = GatewayEVM(gatewayAddress); | ||
| universal = universalAddress; | ||
| gasLimitAmount = gas; | ||
| } |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
Comment on lines
+93
to
+112
| function onCall( | ||
| MessageContext calldata context, | ||
| bytes calldata message | ||
| ) external payable onlyGateway returns (bytes4) { | ||
| if (context.sender != universal) revert Unauthorized(); | ||
| ( | ||
| address receiver, | ||
| uint256 amount, | ||
| uint256 gasAmount, | ||
| address sender | ||
| ) = abi.decode(message, (address, uint256, uint256, address)); | ||
| _mint(receiver, amount); | ||
| if (gasAmount > 0) { | ||
| if (sender == address(0)) revert InvalidAddress(); | ||
| (bool success, ) = payable(sender).call{value: gasAmount}(""); | ||
| if (!success) revert GasTokenTransferFailed(); | ||
| } | ||
| emit TokenTransferReceived(receiver, amount); | ||
| return ""; | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities Low
Comment on lines
+93
to
+112
| function onCall( | ||
| MessageContext calldata context, | ||
| bytes calldata message | ||
| ) external payable onlyGateway returns (bytes4) { | ||
| if (context.sender != universal) revert Unauthorized(); | ||
| ( | ||
| address receiver, | ||
| uint256 amount, | ||
| uint256 gasAmount, | ||
| address sender | ||
| ) = abi.decode(message, (address, uint256, uint256, address)); | ||
| _mint(receiver, amount); | ||
| if (gasAmount > 0) { | ||
| if (sender == address(0)) revert InvalidAddress(); | ||
| (bool success, ) = payable(sender).call{value: gasAmount}(""); | ||
| if (!success) revert GasTokenTransferFailed(); | ||
| } | ||
| emit TokenTransferReceived(receiver, amount); | ||
| return ""; | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Comment on lines
+40
to
+51
| function __UniversalTokenCore_init( | ||
| address gatewayAddress, | ||
| uint256 gas, | ||
| address uniswapRouterAddress | ||
| ) internal { | ||
| if (gatewayAddress == address(0) || uniswapRouterAddress == address(0)) | ||
| revert InvalidAddress(); | ||
| if (gas == 0) revert InvalidGasLimit(); | ||
| gateway = GatewayZEVM(payable(gatewayAddress)); | ||
| uniswapRouter = uniswapRouterAddress; | ||
| gasLimitAmount = gas; | ||
| } |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
Comment on lines
+66
to
+127
| function transferCrossChain( | ||
| address destination, | ||
| address receiver, | ||
| uint256 amount | ||
| ) public payable { | ||
| if (msg.value == 0) revert ZeroMsgValue(); | ||
| if (receiver == address(0)) revert InvalidAddress(); | ||
|
|
||
| _burn(msg.sender, amount); | ||
|
|
||
| emit TokenTransfer(destination, receiver, amount); | ||
|
|
||
| (address gasZRC20, uint256 gasFee) = IZRC20(destination) | ||
| .withdrawGasFeeWithGasLimit(gasLimitAmount); | ||
| if (destination != gasZRC20) revert InvalidAddress(); | ||
|
|
||
| address WZETA = gateway.zetaToken(); | ||
|
|
||
| IWETH9(WZETA).deposit{value: msg.value}(); | ||
| if (!IWETH9(WZETA).approve(uniswapRouter, msg.value)) { | ||
| revert ApproveFailed(); | ||
| } | ||
|
|
||
| uint256 out = SwapHelperLib.swapTokensForExactTokens( | ||
| uniswapRouter, | ||
| WZETA, | ||
| gasFee, | ||
| gasZRC20, | ||
| msg.value | ||
| ); | ||
|
|
||
| uint256 remaining = msg.value - out; | ||
|
|
||
| if (remaining > 0) { | ||
| IWETH9(WZETA).withdraw(remaining); | ||
| (bool success, ) = msg.sender.call{value: remaining}(""); | ||
| if (!success) revert TransferFailed(); | ||
| } | ||
|
|
||
| bytes memory message = abi.encode(receiver, amount, 0, msg.sender); | ||
|
|
||
| CallOptions memory callOptions = CallOptions(gasLimitAmount, false); | ||
|
|
||
| RevertOptions memory revertOptions = RevertOptions( | ||
| address(this), | ||
| true, | ||
| address(0), | ||
| abi.encode(amount, msg.sender), | ||
| gasLimitAmount | ||
| ); | ||
|
|
||
| if (!IZRC20(gasZRC20).approve(address(gateway), gasFee)) { | ||
| revert ApproveFailed(); | ||
| } | ||
| gateway.call( | ||
| abi.encodePacked(connected[destination]), | ||
| destination, | ||
| message, | ||
| callOptions, | ||
| revertOptions | ||
| ); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls Warning
Comment on lines
+129
to
+174
| function onCall( | ||
| MessageContext calldata context, | ||
| address zrc20, | ||
| uint256 amount, | ||
| bytes calldata message | ||
| ) external override onlyGateway { | ||
| if (context.sender != connected[zrc20]) revert Unauthorized(); | ||
| ( | ||
| address destination, | ||
| address receiver, | ||
| uint256 tokenAmount, | ||
| address sender | ||
| ) = abi.decode(message, (address, address, uint256, address)); | ||
| if (destination == address(0)) { | ||
| _mint(receiver, tokenAmount); | ||
| } else { | ||
| (address gasZRC20, uint256 gasFee) = IZRC20(destination) | ||
| .withdrawGasFeeWithGasLimit(gasLimitAmount); | ||
| if (destination != gasZRC20) revert InvalidAddress(); | ||
| uint256 out = SwapHelperLib.swapExactTokensForTokens( | ||
| uniswapRouter, | ||
| zrc20, | ||
| amount, | ||
| destination, | ||
| 0 | ||
| ); | ||
| if (!IZRC20(destination).approve(address(gateway), out)) { | ||
| revert ApproveFailed(); | ||
| } | ||
| gateway.withdrawAndCall( | ||
| abi.encodePacked(connected[destination]), | ||
| out - gasFee, | ||
| destination, | ||
| abi.encode(receiver, tokenAmount, out - gasFee, sender), | ||
| CallOptions(gasLimitAmount, false), | ||
| RevertOptions( | ||
| address(this), | ||
| true, | ||
| address(0), | ||
| abi.encode(tokenAmount, sender), | ||
| 0 | ||
| ) | ||
| ); | ||
| } | ||
| emit TokenTransferToDestination(destination, receiver, amount); | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities Low
|
Throws an error when adding liquidity: |
fadeev
commented
Jan 7, 2025
Comment on lines
+104
to
+113
| router.addLiquidity( // throws error | ||
| address(zetaToken), | ||
| address(zrc20), | ||
| 10 ether, | ||
| 10 ether, | ||
| 1 ether, | ||
| 1 ether, | ||
| owner, | ||
| block.timestamp + 300 | ||
| ); |
There was a problem hiding this comment.
@skosito I'm getting errors when trying to add liquidity. Is there anything wrong I'm doing here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.