-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set gateway address to a placeholder #30
base: main
Are you sure you want to change the base?
Conversation
If I switch back to the [dependencies]
Sui = { git = "https://github.com/MystenLabs/sui.git", subdir = "crates/sui-framework/packages/sui-framework", rev = "framework/testnet" }
gateway = { git = "https://github.com/zeta-chain/protocol-contracts-sui.git", rev = "main" }
[addresses]
call = "0x0"
gateway = "0x2c8aa332520a3c3984c84c9acedeaee5421a327e031692530724b4f280516c8f" The build fails:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running sui move test
works
But running sui move build
fails with
sui move build
UPDATING GIT DEPENDENCY https://github.com/MystenLabs/sui.git
Failed to build Move modules: Unresolved addresses found. To fix this, add an entry for each unresolved address to the [addresses] section of ./Move.toml: e.g.,
[addresses]
std = "0x1"
Alternatively, you can also define [dev-addresses] and call with the -d flag
Caused by:
Unresolved addresses: [
Named address 'gateway' in package 'gateway'
].
@lumtis can we use |
For the time being it might be fine
But I'm not sure this will allow use to deploy the package in prod with this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now in case this unblock the localnet
With this placeholder, when I import the Gateway from an example project, it seems to compile fine:
https://stackoverflow.com/questions/73958046/local-dependency-cannot-be-resolved/73959597