refactor: update cosmos and tendermint #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skosito
commented
Apr 30, 2024
skosito
commented
Apr 30, 2024
6 tasks
lumtis
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates cosmos sdk to 0.47.10, and replaces tendermint with comet.
Also, in order to remove tendermint from indirect dependency, binance-sdk/types has to be removed. I replaced it with cosmos-sdk types, but not sure if this is ok, seems like only AccAddress is used from there.
If we don't change this binance-sdk/types to cosmos types, tendermint will only be indirect dependency, which should be ok, so if needed this change can be reverted.
On master, compilation is broken - with introduction of password in tss constructor, it was not used on couple of places. Also test4nodes test is failing on master, it can be follow up work to stabilize that a bit.