Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example descriptions in package.json #231

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Example descriptions in package.json #231

merged 3 commits into from
Feb 5, 2025

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jan 26, 2025

Summary by CodeRabbit

  • Documentation

    • Updated README files for multiple example projects (Call, Hello, NFT, Swap, Token)
    • Refined project titles and descriptions
    • Added or updated tutorial links for each example project
  • Chores

    • Renamed package names from "example-template" to specific project names (call, hello, nft, swap, token)
    • Added descriptive package descriptions for each example project

Copy link

coderabbitai bot commented Jan 26, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request encompasses comprehensive updates to the ZetaChain example repositories, focusing on renaming and refining documentation across multiple example projects. The changes standardize package names, enhance descriptions, and update tutorial links, providing a more cohesive and informative developer experience across the Call, Hello, NFT, Swap, and Token example repositories.

Changes

File Changes
examples/*/README.md - Updated titles to more descriptive names (e.g., "Hello Example" → "Call Example")
- Removed trailing slashes from tutorial URLs
- Simplified or added documentation links
examples/*/package.json - Renamed name from "example-template" to project-specific names (call, hello, nft, swap, token)
- Added descriptive description fields explaining project functionality

Possibly related PRs

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08ebf52 and 1b623fc.

📒 Files selected for processing (7)
  • examples/call/package.json (1 hunks)
  • examples/hello/package.json (1 hunks)
  • examples/nft/README.md (1 hunks)
  • examples/nft/package.json (2 hunks)
  • examples/swap/package.json (2 hunks)
  • examples/token/README.md (1 hunks)
  • examples/token/package.json (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fadeev fadeev marked this pull request as ready for review January 27, 2025 10:51
@fadeev fadeev requested a review from a team as a code owner January 27, 2025 10:51
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (7)
examples/token/package.json (1)

4-4: Fix grammatical error in description.

The description contains a grammatical error. The phrase "to minted" should be "to be minted".

-  "description": "Universal Token enables ERC-20 tokens to minted and transferred between connected chains",
+  "description": "Universal Token enables ERC-20 tokens to be minted and transferred between connected chains",
examples/nft/package.json (1)

4-4: Fix grammatical error in description.

The description contains a grammatical error. The phrase "to minted" should be "to be minted".

-  "description": "Universal NFT enables non-fungible ERC-721 tokens to minted and transferred between connected chains.",
+  "description": "Universal NFT enables non-fungible ERC-721 tokens to be minted and transferred between connected chains.",
examples/hello/README.md (1)

3-3: Format URL as proper markdown link

Convert the bare URL to a properly formatted markdown link for better readability and compliance with markdown best practices.

-Tutorial: https://www.zetachain.com/docs/developers/tutorials/hello
+Tutorial: [ZetaChain Hello Tutorial](https://www.zetachain.com/docs/developers/tutorials/hello)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/call/README.md (1)

3-3: Format URL as proper markdown link

Convert the bare URL to a properly formatted markdown link for consistency with other documentation.

-Tutorial: https://www.zetachain.com/docs/developers/tutorials/call
+Tutorial: [ZetaChain Call Tutorial](https://www.zetachain.com/docs/developers/tutorials/call)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/nft/README.md (1)

3-3: Standardize documentation format

  1. Convert the bare URL to a properly formatted markdown link
  2. Consider using consistent "Tutorial:" prefix as used in other examples
-Learn more: https://www.zetachain.com/docs/developers/standards/nft
+Tutorial: [ZetaChain NFT Documentation](https://www.zetachain.com/docs/developers/standards/nft)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/swap/README.md (1)

3-3: Format URL as proper markdown link

Convert the bare URL to a properly formatted markdown link for better documentation standards.

-Tutorial: https://www.zetachain.com/docs/developers/tutorials/swap
+Tutorial: [ZetaChain Swap Tutorial](https://www.zetachain.com/docs/developers/tutorials/swap)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/token/README.md (1)

3-3: Standardize documentation format

  1. Convert the bare URL to a properly formatted markdown link
  2. Consider using consistent "Tutorial:" prefix as used in other examples
-Learn more: https://www.zetachain.com/docs/developers/standards/token
+Tutorial: [ZetaChain Token Documentation](https://www.zetachain.com/docs/developers/standards/token)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

3-3: Bare URL used
null

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77d0fbf and 08ebf52.

📒 Files selected for processing (10)
  • examples/call/README.md (1 hunks)
  • examples/call/package.json (1 hunks)
  • examples/hello/README.md (1 hunks)
  • examples/hello/package.json (1 hunks)
  • examples/nft/README.md (1 hunks)
  • examples/nft/package.json (2 hunks)
  • examples/swap/README.md (1 hunks)
  • examples/swap/package.json (2 hunks)
  • examples/token/README.md (1 hunks)
  • examples/token/package.json (2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
examples/call/README.md

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/hello/README.md

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/nft/README.md

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/swap/README.md

3-3: Bare URL used
null

(MD034, no-bare-urls)

examples/token/README.md

3-3: Bare URL used
null

(MD034, no-bare-urls)

🔇 Additional comments (4)
examples/hello/package.json (1)

2-4: LGTM! Clear and concise package metadata.

The package name and description accurately reflect the example's purpose.

examples/call/package.json (1)

2-4: LGTM! Clear and concise package metadata.

The package name and description accurately reflect the example's purpose.

examples/swap/package.json (2)

2-4: LGTM! Clear and concise package metadata.

The package name and description accurately reflect the example's purpose.


2-2: LGTM! Consistent versioning across examples.

All example packages maintain version "1.0.0", which is good practice for a collection of related examples.

Also applies to: 3-3

@fadeev fadeev changed the title descriptions Example descriptions in package.json Jan 27, 2025
@fadeev
Copy link
Member Author

fadeev commented Jan 29, 2025

@zeta-chain/smart-contracts please, review.

1 similar comment
@fadeev
Copy link
Member Author

fadeev commented Feb 4, 2025

@zeta-chain/smart-contracts please, review.

@fadeev fadeev merged commit 67911fb into main Feb 5, 2025
5 checks passed
@fadeev fadeev deleted the descriptions branch February 5, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants