Skip to content

Commit

Permalink
update baseline mac deployment target to 10.15
Browse files Browse the repository at this point in the history
  • Loading branch information
minrk committed Jan 30, 2025
1 parent 0dd3637 commit 3717eec
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
continue-on-error: ${{ matrix.zmq == 'head' }}

env:
MACOSX_DEPLOYMENT_TARGET: "11.7"
MACOSX_DEPLOYMENT_TARGET: "13.7"

strategy:
fail-fast: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
name: wheel-${{ matrix.name }}

env:
MACOSX_DEPLOYMENT_TARGET: "10.9"
MACOSX_DEPLOYMENT_TARGET: "10.15"
CIBW_BUILD: "${{ matrix.cibw.build || '*' }}"
CIBW_SKIP: "${{ matrix.cibw.skip || '' }}"
CIBW_ARCHS: "${{ matrix.cibw.arch || 'auto' }}"
Expand Down
7 changes: 1 addition & 6 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,8 @@ before-all = "bash tools/install_libzmq.sh"
repair-wheel-command = "delocate-wheel --sanitize-rpaths --require-archs {delocate_archs} -w {dest_dir} -v {wheel}"

[tool.cibuildwheel.macos.environment]
# note: everything here needs to also be duplicated in overrides below
ZMQ_PREFIX = "/tmp/zmq"
MACOSX_DEPLOYMENT_TARGET = "10.9"
MACOSX_DEPLOYMENT_TARGET = "10.15"

[tool.cibuildwheel.windows]
before-all = "python buildutils/bundle.py licenses"
Expand All @@ -190,10 +189,6 @@ repair-wheel-command = """\
"cmake.define.ZMQ_HAVE_IPC" = "OFF"
"cmake.define.POLLER" = "select"

# mac-arm target is 10.15
[[tool.cibuildwheel.overrides]]
select = "*macos*{universal2,arm64}*"
environment = { ZMQ_PREFIX = "/tmp/zmq", MACOSX_DEPLOYMENT_TARGET = "10.15" }

# manylinux2010 for (less) old cp37-9, pp37-8
[[tool.cibuildwheel.overrides]]
Expand Down
3 changes: 3 additions & 0 deletions tools/install_libzmq.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ LICENSE_DIR="$PYZMQ_DIR/licenses"
test -d "$LICENSE_DIR" || mkdir "$LICENSE_DIR"

if [[ "$(uname)" == "Darwin" ]]; then
# make sure deployment target is set
echo "${MACOSX_DEPLOYMENT_TARGET=}"
test ! -z "${MACOSX_DEPLOYMENT_TARGET}"
# need LT_MULTI_MODULE or libtool will strip out
# all multi-arch symbols at the last step
export LT_MULTI_MODULE=1
Expand Down

0 comments on commit 3717eec

Please sign in to comment.