Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README with accurate Dockerfile generation instructions #137

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

JackGod001
Copy link

  • Clarify the directory for running Dockerfile generation command

Description:
This PR updates the README to provide more accurate instructions for Dockerfile generation, specifically addressing the handling of go.mod and go.sum files, as well as the go mod download command.

Background:
The currently generated Dockerfile contains the following hardcoded instructions:

ADD go.mod .
ADD go.sum .
RUN go mod download

- Clarify the directory for running Dockerfile generation command
- Explain hardcoded Go module handling in generated Dockerfile
- Add note about potential manual adjustments for different project structures
@kevwan kevwan merged commit ad34c51 into zeromicro:feat/v3 Sep 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants