-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: redis reacquire #4319
fix: redis reacquire #4319
Conversation
locker id just use as release key |
Thanks for your contribution! Would you please resolve conflicts? |
done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
go-zero's redis lock is a bit like etcd's lease.
So the lock's owner can call |
that' s a good explanation, but I think the lock should be for other language users not to create ambiguity. because distributed locks can't be reowned even by themselves |
a typical example is 'redis set nx ex' |
It's better to do a rebase, which will make your changes easy to review. |
new pr: #4325 |
|
see: TestRedisLock_SameAcquire test