Aghostpatch#252
Open
WhatTheFlip339 wants to merge 18 commits into
Open
Conversation
Clear previous aghost body attributes before setting a new one.
Refactor set_ssd_indicator to handle state and overlay logic more clearly.
Owner
|
Something I noticed is that verbs such as laughing & coughing (ie built in emotes) duplicate even when not aghosted |
Owner
second note - this also applies to subtlers lmao |
Contributor
Author
|
if anyone has any ideas to make it work better I am all ears |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Improves aghost to be client related and not mob specific. Also made it so you only get body messages from the last mob you aghosted from.
I am not sure if admins want body messages to only occur if the body is alive, right now you get messages while your aghosted and your body is dead.
Testing Evidence
Why It's Good For The Game
Bugs bad