[v1.5 Migration - REVIEW] Domain Migration: Backend Registration/Transfer [WIP] #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whytecrowe
changed the title
[WIP] [Migration ZChain] Domain Migration: Backend Registration/Transfer
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/zns-meowchain #112 +/- ##
=================================================
Coverage 99.80% 99.80%
=================================================
Files 11 11
Lines 525 525
Branches 117 117
=================================================
Hits 524 524
Misses 1 1 |
Whytecrowe
force-pushed
the
rc/zns-meowchain
branch
from
2a958a1 to
d0e1ae5
Compare
Whytecrowe
changed the title
…erify configs if we're not replicating them. owner after transfer still an issue
…dynamic network change if possible otherwise write to file and read in second script
…tions. Local testing, testing on a testnet like sepolia, and testing on real meowchain
…of meowchain. Issues using ZDC for local deployment after undoing forking on hardhat, use older test helper for now
… and return registeredDomains array properly
…ode is scratchy right now, working on way to reliably get domainHashes from all the calls
…ation here. still have to deploy changes for bulk txs
… bulk event log parsing
…d throw errors properly
…few domains with success
…is to abstract the registration loops that are also used in hh flow
…er of domains we can fit in a single bulk tx
…rough registry still breaks subdomain registration
JamesEarle
force-pushed
the
meow-domain-migration-code
branch
from
19c4b3e to
0a02499
Compare
…g multi level domain parents having locked access types, now work on transfer subdomains after register
Whytecrowe
changed the title
Whytecrowe
changed the base branch from
rc/zns-meowchain
to
rc/zchain-native-main
Whytecrowe
changed the title
Whytecrowe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be heavily reviewed and NOT MERGED!
Work here could be reused in another proper PR that is based on the current (or proper) version of the code!
Figure out what this is, finalize how it works and decide what to do with this!