Skip to content

drivers: ethernet: phy: add driver for ksz9131 #90711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 24, 2025
Merged

drivers: ethernet: phy: add driver for ksz9131 #90711

merged 12 commits into from
Oct 24, 2025

Conversation

@TonyHan11
Copy link
Contributor

@TonyHan11 TonyHan11 commented May 28, 2025 •
edited
Loading

This PR includes:

  • add the driver for Microchip KSZ9131 Ethernet PHY
  • add interrupt mode support for KSZ8081

@github-actions github-actions bot requested review from a user, decsny, lmajewski, maass-hamburg and pdgendt May 28, 2025 04:32
@pdgendt
Copy link
Contributor

pdgendt commented May 28, 2025

Add an entry to https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/build_all/ethernet/app.overlay so it builds in CI.

maass-hamburg
maass-hamburg requested changes May 28, 2025
View reviewed changes
@TonyHan11 TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 6944d51 to 5055226 Compare May 28, 2025 08:09
@TonyHan11
Copy link
Contributor Author

@pdgendt An entry for ksz9131 added to tests/drivers/build_all/ethernet/app.overlay, thanks.

@maass-hamburg
Copy link
Member

@TonyHan11 pls add PR description and address the things from sonarqube

@TonyHan11
Copy link
Contributor Author

@maass-hamburg updated with removing the unused property, renaming LINK_*BASED_T and fixing if (ret), thank you very much.

@TonyHan11 TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 5055226 to cfd8c64 Compare May 29, 2025 01:21
maass-hamburg
maass-hamburg requested changes Jun 2, 2025
View reviewed changes
@TonyHan11 TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 4 times, most recently from 1ac4658 to e7778f7 Compare June 3, 2025 04:41
@TonyHan11
Copy link
Contributor Author

@maass-hamburg
Thank you for your comments. Commits updated with the following changes:

  • using goto instead of do while (0)
  • update if (ret) to if (ret < 0)
  • fix the issues reported by SonarQube Cloud
  • remove comments TODO change this to GPIO interrupt driven

maass-hamburg
maass-hamburg reviewed Jun 3, 2025
View reviewed changes
@TonyHan11 TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 2 times, most recently from ffe8e46 to 94224d7 Compare June 9, 2025 04:51
@TonyHan11
Copy link
Contributor Author

Resolve the CI error by rebasing the commits (without changes).

@TonyHan11 TonyHan11 requested a review from maass-hamburg June 9, 2025 05:30
maass-hamburg
maass-hamburg requested changes Jun 10, 2025
View reviewed changes
@TonyHan11 TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 94224d7 to 35d32e6 Compare June 10, 2025 09:27
maass-hamburg
maass-hamburg previously approved these changes Jun 10, 2025
View reviewed changes
kartben
kartben reviewed Jun 26, 2025
View reviewed changes
drivers/ethernet/phy/phy_microchip_ksz9131.c Outdated
reg_val |= PHY_KSZ9131_ICS_LINK_UP_IE_MASK | PHY_KSZ9131_ICS_LINK_DOWN_IE_MASK;

/* Write settings to Interrupt Control/Status register */
ret = ksz9131_write(dev, 27, reg_val);
Copy link
Contributor

@kartben kartben Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use PHY_KSZ9131_ICS_REG macro instead of magic number

kartben
kartben reviewed Jun 26, 2025
View reviewed changes
drivers/ethernet/phy/phy_microchip_ksz8081.c Outdated
goto done;
}

gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,
ret = gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,

@TonyHan11 TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from e85206e to 51e6b47 Compare October 24, 2025 02:45
@TonyHan11
Copy link
Contributor Author

Hi @nandojve ,

Hi @TonyHan11 ,

Is this still relevant to v4.3 ?

Yes, we hope it be merged to v4.3.
I rebased the commits to totay's main branch with 2 errors raised by DevicetreeLinting fixed. Also add some commits on it for supporting the GMAC0 which uses KSZ9131 as the PHY.

nandojve
nandojve previously approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a general look and LGTM!

@nandojve
Copy link
Member

Ping @pdgendt , @maass-hamburg , @kartben .

maass-hamburg
maass-hamburg reviewed Oct 24, 2025
View reviewed changes
@TonyHan11
drivers: ethernet: phy: add Microchip's KSZ9131 PHY support
78fd48a 
Add support for KSZ9131 (Gigabit Ethernet Transceiver with RGMII Support).
As first starter, 100MBit/s mode is tested.
https://www.microchip.com/en-us/product/ksz9131

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
tests: drivers: build_all: ethernet: add new lines between PHY nodes
af33d01 
New lines are expected between PHY nodes by DevicetreeLinting.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
tests: drivers: build_all: ethernet: add KSZ9131 entry
62121ac 
Add build tests for Microchip KSZ9131.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
drivers: ethernet: phy: ksz9131: add support for phy interrupt mode
e89bc0c 
Enable Link-Up and Link-Down interrupts. On the interrupt handling
the monitor work is scheduled to update the link status and calling
corresponding callback routine.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
drivers: ethernet: phy: ksz9131: add getting status for gigabit mode
09ae248 
Read gigabit status from Master Slave Status Register.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
drivers: ethernet: phy: ksz9131: save link state for get
a052d3e 
Get the link state in the monitor and save it for get_link api
implementation to use.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
dts: microchip: sam: add nodes for GMAC0 to sama7g5.dtsi
c1ef453 
Add gmac1 and gmac1_mdio nodes.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
soc: microchip: sam: update MMU for sama7g5 GMAC0
fcad1b0 
Enable strong ordered access to the GMAC0 registers.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
soc: microchip: sam: configure the clocks for sama7g5 GMAC0
9327c72 
Configure the generic clocks to 125MHz for GMAC0.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
drivers: ethernet: sam_gmac: update for support RGMII mode
ef9c3f3 
Update to use the RGMII mode which is supported by SAMA7G54.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
boards: microchip: sam: remove extra new lines from sama7g54_ek.dts
1d10573 
Remove extra new lines to satisfy the requirement of DevicetreeLinting.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11
boards: microchip: sam: enable nodes for GMAC0 to sama7g54_ek dts file
f58c6c1 
Enable gmac0, gmac0_mdio and gmac0_phy nodes.

Signed-off-by: Tony Han <[email protected]>
@TonyHan11 TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 51e6b47 to f58c6c1 Compare October 24, 2025 09:30
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cfriedt cfriedt merged commit 18d8ee5 into zephyrproject-rtos:main Oct 24, 2025
28 checks passed
@TonyHan11 TonyHan11 deleted the phy_ksz9131_ksz8081 branch October 27, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdgendt pdgendt pdgendt approved these changes

@nandojve nandojve nandojve approved these changes

@maass-hamburg maass-hamburg maass-hamburg approved these changes

@decsny decsny Awaiting requested review from decsny

@lmajewski lmajewski Awaiting requested review from lmajewski

@kartben kartben Awaiting requested review from kartben

@ClaCodes ClaCodes Awaiting requested review from ClaCodes

@albertofloyd albertofloyd Awaiting requested review from albertofloyd

@ArunMCHP ArunMCHP Awaiting requested review from ArunMCHP

@jvasanth1 jvasanth1 Awaiting requested review from jvasanth1

@nashif nashif Awaiting requested review from nashif

@stephanosio stephanosio Awaiting requested review from stephanosio

@VenkatKotakonda VenkatKotakonda Awaiting requested review from VenkatKotakonda

Assignees

@maass-hamburg maass-hamburg

Labels

area: Boards/SoCs area: Devicetree Bindings area: Ethernet area: Tests Issues related to a particular existing or missing test platform: Microchip MEC Microchip MEC Platform platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

7 participants

@TonyHan11 @pdgendt @maass-hamburg @nandojve @kartben @cfriedt @zephyrbot