Add driver for Vishay RGBIR sensor VEML6046 #90091

it-klinger · 2025-05-17T09:03:26Z

add driver for Vishay VEML6046 RGBIR color sensor
add new compatible "vishay,veml6046"
support fetch and get sensor subsystem operations
triggered mode and interrupts are not yet supported
add attribution test application which tests all attribute combinations

kartben · 2025-05-23T20:38:17Z

drivers/sensor/vishay/veml6046/veml6046.c

+	uint32_t green_lux;
+	uint32_t blue_lux;
+	uint32_t ir_lux;
+	uint32_t int_flags;


Unused. I'll remove.

kartben · 2025-05-23T20:40:46Z

drivers/sensor/vishay/veml6046/veml6046.c

+	case SENSOR_ATTR_LOWER_THRESH:
+		val->val1 = data->thresh_low;
+		break;
+	case SENSOR_ATTR_UPPER_THRESH:
+		val->val1 = data->thresh_high;
+		break;


should convert back to lux

kartben · 2025-05-23T20:43:25Z

drivers/sensor/vishay/veml6046/veml6046.c

+		return ret;
+	}
+
+	ret = veml6046_read16(dev, VEML6046_CMDCODE_INT_L, val);


may want to actually check ret?

kartben · 2025-05-23T20:44:45Z

samples/sensor/veml6046/src/main.c

+	sensor_channel_get(dev, SENSOR_CHAN_RED, &red);
+	sensor_channel_get(dev, SENSOR_CHAN_VEML6046_RED_RAW_COUNTS, &red_raw);
+
+	sensor_channel_get(dev, SENSOR_CHAN_RED, &green);


Suggested change

sensor_channel_get(dev, SENSOR_CHAN_RED, &green);

sensor_channel_get(dev, SENSOR_CHAN_GREEN, &green);

kartben · 2025-05-23T20:46:25Z

samples/sensor/veml6046/src/main.c

+	sensor_channel_get(dev, SENSOR_CHAN_RED, &green);
+	sensor_channel_get(dev, SENSOR_CHAN_VEML6046_GREEN_RAW_COUNTS, &green_raw);
+
+	sensor_channel_get(dev, SENSOR_CHAN_RED, &blue);


Suggested change

sensor_channel_get(dev, SENSOR_CHAN_RED, &blue);

sensor_channel_get(dev, SENSOR_CHAN_BLUE, &blue);

kartben · 2025-05-23T20:46:40Z

samples/sensor/veml6046/src/main.c

+	sensor_channel_get(dev, SENSOR_CHAN_RED, &blue);
+	sensor_channel_get(dev, SENSOR_CHAN_VEML6046_BLUE_RAW_COUNTS, &blue_raw);
+
+	sensor_channel_get(dev, SENSOR_CHAN_RED, &ir);


Suggested change

sensor_channel_get(dev, SENSOR_CHAN_RED, &ir);

sensor_channel_get(dev, SENSOR_CHAN_IR, &ir);

sonarqubecloud · 2025-05-26T13:47:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-07-26T00:39:57Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

it-klinger · 2025-08-10T07:17:41Z

Hi,
can anybody review the patch, please?
I think i changed everything according to the review or did i miss something?

kartben · 2025-08-10T09:19:15Z

Hi,
can anybody review the patch, please?
I think i changed everything according to the review or did i miss something?

It will be possible as soon as you restore https://github.com/it-klinger/zephyr/tree/add-veml6046 to commit d7051b9 which is what it was when the PR was closed. Hope this helps!

it-klinger · 2025-08-10T10:43:32Z

Hi Benjamin,
i restored to d7051b9 and also did a small change and force commited, but the PR is not opening again.

kartben · 2025-08-10T11:05:29Z

Hi Benjamin,
i restored to d7051b9 and also did a small change and force commited, but the PR is not opening again.

It's only when the branch is exactly at that commit that reopening will be possible. The follow-up commit will have to be done afterwards

kartben · 2025-08-10T11:11:24Z

Hi Benjamin,
i restored to d7051b9 and also did a small change and force commited, but the PR is not opening again.

It's only when the branch is exactly at that commit that reopening will be possible. The follow-up commit will have to be done afterwards

And right now neither of the two commits are d705 anyway main...it-klinger:zephyr:add-veml6046

it-klinger · 2025-08-10T11:47:34Z

Now it's at d705 but i'm only able to open a PR with a new number (#94305), but the closed one is not opened.

josuah

Thank you for the successive modifications and improvements!

MaureenHelm · 2025-10-22T15:40:10Z

Rebase needed

- add driver for Vishay VEML6046 RGBIR color sensor - add new compatible "vishay,veml6046" - support fetch and get sensor subsystem operations - triggered mode and interrupts are not yet supported Signed-off-by: Andreas Klinger <[email protected]>

- Test all attribute combinations of Vishay RGBIR color sensor VEML6046. - Print OVERFLOW in case of saturation of sensor. - This small program is intended to be helping when finding appropriate attributes for an application of the sensor. Signed-off-by: Andreas Klinger <[email protected]>

it-klinger · 2025-10-22T17:20:05Z

Just rebased.

it-klinger · 2025-10-22T17:20:15Z

Reopened.

- create common header file veml60xx-common.h for sensors VEML6031 and VEML6046. Signed-off-by: Andreas Klinger <[email protected]>

sonarqubecloud · 2025-10-22T18:21:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

it-klinger · 2025-10-22T18:57:37Z

@MaureenHelm @kartben @josuah

Rebasing done.

github-actions bot added area: Samples Samples area: Sensors Sensors labels May 17, 2025

github-actions bot requested review from MaureenHelm, asemjonovs, avisconti, jeppenodgaard, kartben, nashif, teburd, tristan-google, ubieda and yperess May 17, 2025 09:04

github-actions bot assigned MaureenHelm May 17, 2025

it-klinger force-pushed the add-veml6046 branch from 614f384 to b489d11 Compare May 17, 2025 09:40

kartben reviewed May 23, 2025

View reviewed changes

it-klinger force-pushed the add-veml6046 branch 4 times, most recently from 565677d to d7051b9 Compare May 26, 2025 13:18

github-actions bot added the Stale label Jul 26, 2025

github-actions bot closed this Aug 10, 2025

kartben reopened this Aug 10, 2025

it-klinger reopened this Oct 18, 2025

it-klinger dismissed stale reviews from JarmouniA, MaureenHelm, and josuah via 0f2518f October 18, 2025 08:12

zephyrbot requested a review from MaureenHelm October 18, 2025 08:14

it-klinger force-pushed the add-veml6046 branch from 0f2518f to d03591d Compare October 18, 2025 18:31

it-klinger requested review from JarmouniA and josuah October 18, 2025 19:06

josuah previously approved these changes Oct 19, 2025

View reviewed changes

kartben previously approved these changes Oct 20, 2025

View reviewed changes

MaureenHelm previously approved these changes Oct 20, 2025

View reviewed changes

it-klinger closed this Oct 22, 2025

it-klinger force-pushed the add-veml6046 branch from d03591d to fd51dde Compare October 22, 2025 17:17

it-klinger added 2 commits October 22, 2025 19:18

it-klinger reopened this Oct 22, 2025

it-klinger dismissed stale reviews from MaureenHelm, kartben, and josuah via 6977338 October 22, 2025 17:20

zephyrbot requested a review from MaureenHelm October 22, 2025 17:21

drivers: sensor: remove redundancies in veml6031 and veml6046

1555f5a

- create common header file veml60xx-common.h for sensors VEML6031 and VEML6046. Signed-off-by: Andreas Klinger <[email protected]>

it-klinger force-pushed the add-veml6046 branch from 6977338 to 1555f5a Compare October 22, 2025 18:15

kartben approved these changes Oct 22, 2025

View reviewed changes

MaureenHelm approved these changes Oct 22, 2025

View reviewed changes

cfriedt merged commit c93788a into zephyrproject-rtos:main Oct 22, 2025
26 checks passed

	sensor_channel_get(dev, SENSOR_CHAN_RED, &green);
	sensor_channel_get(dev, SENSOR_CHAN_GREEN, &green);

	sensor_channel_get(dev, SENSOR_CHAN_RED, &blue);
	sensor_channel_get(dev, SENSOR_CHAN_BLUE, &blue);

	sensor_channel_get(dev, SENSOR_CHAN_RED, &ir);
	sensor_channel_get(dev, SENSOR_CHAN_IR, &ir);

Add driver for Vishay RGBIR sensor VEML6046 #90091

Add driver for Vishay RGBIR sensor VEML6046 #90091

Uh oh!

Conversation

it-klinger commented May 17, 2025

Uh oh!

kartben May 23, 2025

Choose a reason for hiding this comment

Uh oh!

it-klinger May 25, 2025

Choose a reason for hiding this comment

Uh oh!

kartben May 23, 2025

Choose a reason for hiding this comment

Uh oh!

kartben May 23, 2025

Choose a reason for hiding this comment

Uh oh!

kartben May 23, 2025

Choose a reason for hiding this comment

Uh oh!

kartben May 23, 2025

Choose a reason for hiding this comment

Uh oh!

kartben May 23, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 26, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Jul 26, 2025

Uh oh!

it-klinger commented Aug 10, 2025

Uh oh!

kartben commented Aug 10, 2025

Uh oh!

it-klinger commented Aug 10, 2025

Uh oh!

kartben commented Aug 10, 2025

Uh oh!

kartben commented Aug 10, 2025

Uh oh!

it-klinger commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

josuah left a comment

Choose a reason for hiding this comment

Uh oh!

MaureenHelm commented Oct 22, 2025

Uh oh!

it-klinger commented Oct 22, 2025

Uh oh!

it-klinger commented Oct 22, 2025

Uh oh!

sonarqubecloud bot commented Oct 22, 2025

Quality Gate passed

Uh oh!

it-klinger commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

it-klinger commented Aug 10, 2025 •

edited

Loading