scripts: runners: nrf: Extend the erase options #88551
Open
+65
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Release Notes
github-actions
bot
requested review from
fabiobaltieri,
kartben,
nashif,
pdgendt and
swinslow
|
The first commit touches a sample, it this intended? Also the commit has no body text. |
The correct string is `ERASE_NONE`. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
erase-overhaul
branch
from
7f05c5f to
954c439
Compare
Indeed, a rebase mistake. Thanks for noticing, fixed! |
carlescufi
force-pushed
the
erase-overhaul
branch
from
954c439 to
9a9360b
Compare
nordicjm
previously approved these changes
Apr 14, 2025
anangl
reviewed
Apr 14, 2025
Instead of providing an `--erase-pages` command, generalize it to a new `--erase-mode` one that can be set to `none`, `ranges`, or `all`. This gives the user full control over the erase mode that will be passed on to nrfutil. Signed-off-by: Carles Cufi <[email protected]>
The erase mode for any external memory that is mapped to the address space of the MCU is derived from the internal non-volatile memory erase mode. In order to allow users to override the default value, add a new --ext-erase-mode command-line option that takes an erase mode just like --erase-mode does. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
erase-overhaul
branch
from
9a9360b to
77b2341
Compare
anangl
approved these changes
Apr 14, 2025
fabiobaltieri
approved these changes
Apr 14, 2025
nordicjm
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.