-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Network packet filter fixes #88544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kartben
merged 9 commits into
zephyrproject-rtos:main
from
jukkar:devel/net-pkt-filter-overhaul
Apr 16, 2025
Merged
Network packet filter fixes #88544
kartben
merged 9 commits into
zephyrproject-rtos:main
from
jukkar:devel/net-pkt-filter-overhaul
Apr 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_ip_rules() function is only used if IPv4 or IPv6 filtering is enabled so add checks to avoid unused function warning. Signed-off-by: Jukka Rissanen <[email protected]>
As the network packet filter drops packets without any indication that the packet is dropped, it can be difficult to monitor what is going on in the system when receiving data. The user can now monitor the statistics and see if packets are being dropped because of packet filter activity. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure that we check possible network packet filtering status before accepting the packet. Signed-off-by: Jukka Rissanen <[email protected]>
9e914b9
to
7b6baa2
Compare
pdgendt
previously approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only non-blocking nits
Add helpers and enablers that allow "net filter" shell command to work. Signed-off-by: Jukka Rissanen <[email protected]>
Add a "net filter" command that will allow user to see the current network packet filter configuration. Signed-off-by: Jukka Rissanen <[email protected]>
Add some more useful debug prints when checking packets. Signed-off-by: Jukka Rissanen <[email protected]>
The Ethernet matching needs tweaking so that it will also work with VLAN packets. Signed-off-by: Jukka Rissanen <[email protected]>
Add tests for VLAN matching. Signed-off-by: Jukka Rissanen <[email protected]>
Add a network packet filtering sample to show how the packet filtering can be used. Signed-off-by: Jukka Rissanen <[email protected]>
7b6baa2
to
e6cee80
Compare
Updated according to comments. |
pdgendt
approved these changes
Apr 14, 2025
rlubos
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating following things in network packet filter support:
net filter
net-shell command which shows information about the used filters