socketpair: fix allocated number of buffers #88537
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
cfriedt
approved these changes
Apr 12, 2025
jukkar
approved these changes
Apr 12, 2025
Give the socketpair allocation strategy a name so that users can change the default. Signed-off-by: Jordan Yates <[email protected]>
According to `f9901e8e` and validated by testing, the supplicant only use case only requires 4 socket pairs. 6 pairs are required for the `hostapd` use case. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
250412_socketpair_cnt
branch
from
3c26e55 to
5db2626
Compare
pdgendt
approved these changes
Apr 13, 2025
rlubos
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to f9901e8 and validated by testing, the supplicant only use case only requires 4 socket pairs. 6 pairs are required for the
hostapduse case.