Skip to content

drivers: gpio: mcp23xxx: fix drive mode validation for input pins #100759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbrake wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drivers: gpio: mcp23xxx: fix drive mode validation for input pins #100759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions drivers/gpio/gpio_mcp23xxx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,18 @@ static int mcp23xxx_pin_cfg(const struct device *dev, gpio_pin_t pin, gpio_flags

k_sem_take(&drv_data->lock, K_FOREVER);

if ((bool)(flags & GPIO_SINGLE_ENDED) != config->is_open_drain ||
(bool)(flags & GPIO_LINE_OPEN_DRAIN) != config->is_open_drain) {
ret = -ENOTSUP;
goto done;
/* Validate drive mode flags for output pins only.
* The MCP23xxx hardware has a fixed drive mode per chip variant:
* - MCP23x08/x17: Push-pull outputs only
* - MCP23x09/x18: Open-drain outputs only
* Input pins don't have a drive mode, so skip validation for them.
*/
if (flags & GPIO_OUTPUT) {
if ((bool)(flags & GPIO_SINGLE_ENDED) != config->is_open_drain ||
(bool)(flags & GPIO_LINE_OPEN_DRAIN) != config->is_open_drain) {
ret = -ENOTSUP;
goto done;
}
}

ret = setup_pin_dir(dev, pin, flags);
Expand Down