drivers: display: Change display buffer pitch from pixel to byte #100749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pitch` in `struct display_buffer_descriptor` is defined as "Number of pixels between consecutive rows in the data buffer". Limitation: Some display controller needs the pitch of byte be dividable by an even value (e.g., 4, 64, ...), if the parameter pitch here is the number of pixels, then the RGB888 (3 bytes per pixel) can't work Change the unit of `pitch` from pixel to byte Signed-off-by: Jason Yu <[email protected]>
The `pitch` in `struct display_buffer_descriptor` is changed from "Number of pixels between consecutive rows in the data buffer" to "Number of bytes between consecutive rows in the data buffer". Update the display controller drivers and samples accordingly. Signed-off-by: Jason Yu <[email protected]>
zephyrbot
requested review from
FRASTM,
JarmouniA,
VynDragon,
danieldegrasse,
djiatsaf-st,
duynguyenxa,
etienne-lms,
galak,
gautierg-st,
jfischer-no,
khoa-nguyen-18,
kl-cruz,
mathieuchopstm,
microbuilder and
thenguyenyf
|
Contributor
|
Thanks, I support this initiative, will try to do a review and testing. |
| static struct co5300_data co5300_data_##node_id = { \ | ||
| .pixel_format = DT_INST_PROP(node_id, pixel_format), \ | ||
| .frame_ptr = CO5300_FRAMEBUFFER(node_id), \ | ||
| .frame_pitch = ROUND_UP(DT_INST_PROP(node_id, width), \ |
Contributor
There was a problem hiding this comment.
Do not delete this, frame pitch needs a initial value after system init
|
|
||
| /* Advance source pointer and decrement remaining */ | ||
| if (local_desc.pitch > local_desc.width) { | ||
| if (local_desc.pitch > local_desc.width * data->bytes_per_pixel) { |
Contributor
There was a problem hiding this comment.
local_desc.pitch > (local_desc.width * data->bytes_per_pixel)?
| LCDIF_SetFrameBufferConfig(config->base, 0, &fbConfig); | ||
|
|
||
| if (bytes_per_pixel == 3U) { | ||
| /* For RGB888 the stride shall be calculated as |
Contributor
There was a problem hiding this comment.
For pitch in bytes it shall follow the same law here
| .buf_size = (w * h) / 8U, | ||
| .width = w, | ||
| .pitch = w, | ||
| .pitch = DIV_ROUND_UP(w, 8), |
Contributor
There was a problem hiding this comment.
Need to updatelvgl_display_16bit/24bit/32bit as well?
| } | ||
|
|
||
| buf_desc.pitch = ROUND_UP(rect_w, CONFIG_SAMPLE_PITCH_ALIGN); | ||
| switch (capabilities.current_pixel_format) { |
Contributor
There was a problem hiding this comment.
May be separate a function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pitchinstruct display_buffer_descriptoris defined as "Number of pixels between consecutive rows in the data buffer".Limitation:
Some display controller needs the pitch of byte be dividable by an even value (e.g., 4, 64, ...), if the parameter pitch here is the number of pixels, then the RGB888 (3 bytes per pixel) can't work
Change the unit of
pitchfrom pixel to byte.For easy review: