drivers: modem/wifi/ethernet: Fix some more net API use #100748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In e6daacf the mayority of the Zephyr ethernet drivers were changed to use the Zephyr native net_ prefixed types, but this one was forgotten. Without this fix/change the code still builds as we are by now setting CONFIG_NET_NAMESPACE_COMPAT_MODE. But when this is not set, things fail to build. Signed-off-by: Alberto Escolar Piedras <[email protected]>
zephyrbot
added
platform: Silabs
zephyrbot
requested review from
ClaCodes,
Kludentwo,
MaochenWang1,
Martinhoff-maker,
SeppoTakalo,
decsny,
jerome-pouiller,
krish2718,
lmajewski,
loicpoulain,
pdgendt,
rerickson1 and
ssharks
rlubos
previously approved these changes
Dec 9, 2025
rerickson1
previously approved these changes
Dec 9, 2025
fabiobaltieri
previously approved these changes
Dec 9, 2025
In b5588ed the mayority of the Zephyr modem drivers were changed to use the Zephyr native net_ prefixed types, but this one was forgotten. Without this fix/change the code still builds as we are by now setting CONFIG_NET_NAMESPACE_COMPAT_MODE. But when this is not set, things fail to build. Note that the net_offload struct was updated accordingly in d45cd67 Signed-off-by: Alberto Escolar Piedras <[email protected]>
In d45cd67 the mayority of the Zephyr codebased was changed to use the Zephyr native net_ prefixed types. This comment was fogotten. Let's fix it. Signed-off-by: Alberto Escolar Piedras <[email protected]>
In 55c49cd the mayority of the Zephyr wifi drivers was changed to use the Zephyr native net_ prefixed types, but some were forgotten. Without this fix/change the code still builds as we are by now setting CONFIG_NET_NAMESPACE_COMPAT_MODE. But when this is not set, things will fail to build. Note that the net_offload struct was updated accordingly in d45cd67 Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
dismissed stale reviews from fabiobaltieri, rerickson1, and rlubos
via
23a8f0b
aescolar
force-pushed
the
net_cleanup_part1
branch
from
f9cf389 to
23a8f0b
Compare
Member
Author
|
Last push was just fixing a few more missing renames in one of the drivers being changed in this PR. |
zephyrbot
requested review from
asmellby,
jhedberg,
maass-hamburg,
rerickson1 and
rlubos
maass-hamburg
approved these changes
Dec 10, 2025
|
rlubos
approved these changes
Dec 10, 2025
SeppoTakalo
approved these changes
Dec 10, 2025
krish2718
approved these changes
Dec 10, 2025
jerome-pouiller
approved these changes
Dec 10, 2025
rerickson1
approved these changes
Dec 10, 2025
jukkar
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #99169 the mayority of the Zephyr drivers were changed to use the Zephyr native net_ prefixed types, but some symbols were forgotten.
Without these fixes/changes the code still builds in most cases as we are by now setting CONFIG_NET_NAMESPACE_COMPAT_MODE.
But when this is not set, things fail to build.
Note that the net_offload struct was updated accordingly in d45cd67
There is currently a failure in main:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/19997797171