drivers: counter: microchip: Add counter using TCC timer #100745
+909
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the binding yaml for tcc peripheral Signed-off-by: Muhammed Asif <[email protected]>
mchp-asif
force-pushed
the
g1_counter_tcc_upstream
branch
3 times, most recently
from
dfa126f to
d4232d4
Compare
- Adds support for g1 counter driver with tcc peripheral Signed-off-by: Muhammed Asif <[email protected]>
- Updates the supported section of the board yaml file Signed-off-by: Muhammed Asif <[email protected]>
mchp-asif
force-pushed
the
g1_counter_tcc_upstream
branch
from
d4232d4 to
dd0a274
Compare
Added sam_e54_xpro.overlay files for tcc. Added sam_e54_xpro platform allow in testcase.yaml. Signed-off-by: Farsin NASAR V A <[email protected]>
mchp-asif
force-pushed
the
g1_counter_tcc_upstream
branch
from
dd0a274 to
145b3f2
Compare
|
zephyrbot
added
area: Devicetree Bindings
area: Counter
platform: Microchip MEC
zephyrbot
requested review from
ArunMCHP,
VenkatKotakonda,
albertofloyd,
jvasanth1,
nandojve,
nashif,
nordic-krch and
stephanosio
nandojve
changed the title
nandojve
requested changes
Dec 11, 2025
|
|
||
| struct tcc_counter_irq_map { | ||
| const uint32_t ovf_irq_line; /* Overflow interrupt number */ | ||
| const uint32_t comp_irq_line[6u]; /* Channel interrupt number */ |
|
|
||
| p_regs->TCC_PER = max_counter_value; | ||
|
|
||
| for (uint8_t index = 0u; index < max_channels; index++) { |
Member
There was a problem hiding this comment.
Should we capture a error related to the max_channels ? I mean what is the maximum channels available.
Is this defined by the
If yes, I think there is a way to define max value to the property then at compile time we pick greater then values.
|
|
||
| data->channel_data[channel].callback = NULL; | ||
| cc_value = data->channel_data[channel].compare_value; | ||
| if (cb != NULL) { |
Member
There was a problem hiding this comment.
Add an empty line before the if ()
Comment on lines
-8
to
+9
| platform_exclude: nucleo_f302r8 | ||
| platform_exclude: | ||
| - nucleo_f302r8 |
Member
There was a problem hiding this comment.
In the future, try to make the changes
- platform_exclude: nucleo_f302r8
+ platform_exclude:
+ - nucleo_f302r8In a separete commit. This helps if we need to rollback code. I know this example is very small but the principle can be used for simple things or more elaborated ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds g1 driver for counter using tcc peripheral