-
Notifications
You must be signed in to change notification settings - Fork 21
Align WorkQueueBuilder with new workqueue work timeout feature #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Align WorkQueueBuilder with new workqueue work timeout feature #86
Conversation
Ensure that all tests and samples start with 'sample.rust' or 'test.rust' to avoid conflict with names in the main Zephyr tree. Signed-off-by: David Brown <[email protected]>
Remove the integration platform, which was with a platform not listed in the supported platforms. Signed-off-by: David Brown <[email protected]>
0d66fd1
to
10be7f8
Compare
The k_work_q has been extended with a new feature, the work timeout, which comes with a new field to k_work_queue_config, work_timeout_ms, which must be initialized. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
10be7f8
to
5fc831d
Compare
Thank you for your contribution. I am actually in the midst of a bit of an overhaul of how the workqueue code works, so we'll have to rework this a bit at that point. Probably my main concern is that with the current code, the work will actually get leaked if it is aborted due to a timeout. I'll try to think if there is a way to deal with this. One thing I have planned to add is to allow my new |
I think the only practical way to get this into both Zephyr and Rust is going to be to add the support based on some conditional ( |
Modules in zephyr constantly need to be updated and synced, this is not an issue :) The process is this:
The problem here is that the module itself is running its own CI, against an incorrect version of zephyr, IE, not the one being created in step 2. The CI in this PR here should be ignored, as it is not tracking zephyr. |
The feature comes with a new parameter to be initialized using the WorkQueueBuilder.