Implement a proc-macros threads creation #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
reviewed
Apr 18, 2025
| /// | ||
| /// Will block until the thread has terminated. | ||
| /// | ||
| /// TODO: Allow a timeout? |
There was a problem hiding this comment.
It would be smart to allow a timeout and return the integer result.
There was a problem hiding this comment.
Actually, would it make more sense to do something similar to what std::thread does where we return a Result that can be either Ok or an Err? I guess that's more "rustonic" than integer return values 😅
There was a problem hiding this comment.
I think handling the timeout is a reasonable request. The Result will be Rust-y. But, thinly wrapped.
Allow an explicit timeout to be given to join, replacing the implementation of the blocking one to one that calls it with a Forever timeout. Signed-off-by: David Brown <[email protected]>
cfriedt
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace how Zephyr threads are declared in Rust. Provides a proc-macro to make this fairly straightforward:
This function can then be called, and will return a
ReadThread. This has methods for setting priority, and astartmethod, which returns aRunningThread, which has a join method. The thread can be respawned after it has exited.The thread macro also accepts a
pool_size = nnnparameter, which will create an array of threads, and can be started that many times.