Add CI #12
Merged
Add CI #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephraph
force-pushed
the
add-ci
branch
6 times, most recently
from
e80f92d to
afcd954
Compare
Ran into an issue where one OS build was missing a dep and caused all the other ones to be canceled. I want to be able to see which succeed/fail individually in development, but consolidate them all in main.
I hate that GitHub won't let you just end a test with success without this unfortunate hack.
zephraph
force-pushed
the
add-ci
branch
2 times, most recently
from
2e57ca6 to
86edfa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a build process for the rust binary part of this library. It'll upload that binary to the artifact store after its build. When a PR is merged into master a GitHub release will be generated for all the platform binaries.
I went through a lot of iterations of caching strategies. Here's how it works:
Checkjob that runscargo check, but only after checking if there's been any changes to rust files and configuration. If there hasn't been, once check is done the individual jobs run. If there has been then the individual platform builds are skipped.In the individual platform builds, where possible I cached their dependency installs (e.g.
cargo-xwin).I only use two platforms:
ubuntu-latestandmacos-latest. Windows is cross compiled onubuntu-latestviacargo-xwinandaarch64is cross compiled on the (presumably) x86 mac server.