fix(docs): make matmul README FLOP table use one (decimal) n convention (Fixes #102)#230
Merged
zeokin merged 1 commit intoJul 14, 2026
Conversation
The 'it doesn't fit' table's memory columns use decimal n (128k -> 128000, so one fp32 matrix is 128000**2*4 = 65 GB), but the compute (2n**3) column mixed conventions: 1k/16k/32k used binary n (1024/16384/32768 -> 2.1/8.8/70) while the 128k row already used decimal n (-> 4.2 PFLOP). Binary n overstates 2n**3 by ~7% ((1024/1000)**3 = 1.074), so the column was internally inconsistent. Recompute the first three rows from the same decimal n the memory column uses: 2.1->2.0 GFLOP, 8.8->8.2 TFLOP, 70->66 TFLOP (128k already 4.2 PFLOP). Add a CPU-only arithmetic test pinning the compute column to 2*(decimal n)**3 so it cannot drift back to the mixed-convention figures. Fixes zeokin#102.
zeokin
approved these changes
Jul 14, 2026
zeokin
left a comment
Owner
There was a problem hiding this comment.
Unifies the matmul README FLOP table to a single decimal-n convention; arithmetic test.
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102.
PR kind
Summary
matmul/README.md's "it doesn't fit" table mixes twonconventions within asingle table. The memory columns use decimal
n(128k → 128000, so one fp32matrix is
128000² × 4 = 65 GB, andA+B+C = 196 GB), but thecompute (2n³)column used binary
nfor the first three rows and decimalnfor thelast:
2n³n)2·1024³(binary)2·1000³)2·16384³(binary)2·16000³)2·32768³(binary)2·32000³)2·128000³(decimal — already correct)A binary
noverstates2n³by(1024/1000)³ = 1.074(~7%), so the first threerows were ~7% high and inconsistent with the decimal
nthe same table's memorycolumns use.
Fix
matmul/README.md— recompute the 1k/16k/32k compute cells from the samedecimal
nthe memory columns use:2.1 → 2.0,8.8 → 8.2,70 → 66(128k already 4.2 PFLOP). Numbers-only; +3/−3.
tests/test_matmul_flop_table_units.py(new) — CPU-only arithmetic test thatderives the compute column from
2·(decimal n)³(and a witness that the oldbinary-
nfigures were the inconsistent, larger ones) so the table cannotdrift back to a mixed convention.
Validation
No protected paths (
eval/,docs/,.github/,dashboard/) touched — thisedits
matmul/README.md(package doc, open zone).Result
Documentation-consistency fix; no code path changed, so no accuracy / latency /
VRAM delta.