fix(strategy): report unknown --transform cleanly instead of KeyError traceback (Fixes #199)#206
Open
RealDiligent wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks — this fix is verified and I want to merge it, but it now conflicts with the just-merged #189 ( Please rebase onto the latest |
Contributor
|
This PR currently has merge conflicts with the base branch. Please resolve them within 12 hours or the bot will close the PR automatically. |
a7d10db to
bf79f1d
Compare
… traceback (Fixes zeokin#199)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR kind
Summary
Fixes #199 —
python -m strategy --transform noperaised an uncaughtKeyErrortraceback (exit 1) instead of the project CLI contract (error: …on stderr, exit 2).get_transform()before any GPU work inrunner.run/runner.compareKeyErroralongside the existing(ValueError, RuntimeError, MemoryError)handlerValidation
uv run --extra test python -m pytest tests/test_cli_errors.py -v(9 passed)uv run python -m strategy.smokeuv run --extra test python -m pytest tests/ strategy/tests/ eval/tests/ -qGPU Result (required for feat PRs only)
N/A — fix lane.
Checklist
Co-authored-byfooters for coding agents