feat(i18n): add RTL layout support groundwork (#1061) - #1113
Merged
Conversation
- Add LOCALE_DIRECTIONS map and getLocaleDirection() to i18n/index.js so each locale declares its text direction in one place - Apply dir= and lang= to <html> on init and on every languageChanged event (both in i18n/index.js and reactively in AppContent via useTranslation hook) - Audit Navbar, Marketplace grid, and Pagination for hardcoded physical CSS directional properties; document findings in responsive.css - Add [dir="rtl"] overrides in responsive.css using logical properties (margin-inline-start, flex-direction: row-reverse, etc.) so layouts are ready the moment an RTL locale is added - Add rtlDirection.test.js covering ltr defaults, unknown-locale fallback, and the rtl path for a future Arabic locale Follow-up: add ar/he locale files and uncomment their entries in LOCALE_DIRECTIONS (tracked in zeekman#1061).
|
@iheomadev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up: add ar/he locale files and uncomment their entries in LOCALE_DIRECTIONS (tracked in #1061).
Closes #1061