Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio tooltip logic #21941

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

AaronFeickert
Copy link
Contributor

@AaronFeickert AaronFeickert commented Dec 12, 2024

Earlier work by @osiewicz in #21931 aims to fix audio control tooltips in the title bar to close #21929. However, its logic is not quite correct, and does not match the toggle behavior for the controls.

This PR corrects the logic to match the toggle behavior for the controls. It also updates capitalization and wording for consistency.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 12, 2024
@AaronFeickert
Copy link
Contributor Author

It's not clear why Linux and Windows are failing the linter. There's no failure on macOS, nor locally (which happens to be macOS as well). Insights on this would be appreciated.

@mikayla-maki
Copy link
Member

mikayla-maki commented Dec 12, 2024

It's not clear why Linux and Windows are failing the linter

There are two implementations of the call crate, depending on which platform you're using. You'll need to re-implement the function you added in the cross-platform implementation as well :)

@AaronFeickert
Copy link
Contributor Author

It's not clear why Linux and Windows are failing the linter

There are two implementations of the call crate, depending on which platform you're using. You'll need to re-implement the function you added in the cross-platform implementation as well :)

Ah, got it! I'm new to the codebase and certainly appreciate the information. I just started using Zed and am excited to contribute back to it.

@mikayla-maki
Copy link
Member

No worries! It's a big codebase and things are always changing :D

Glad you're excited, we're happy to have you :D

@mikayla-maki mikayla-maki self-assigned this Dec 12, 2024
@mikayla-maki mikayla-maki merged commit bab6a79 into zed-industries:main Dec 12, 2024
12 checks passed
@mikayla-maki
Copy link
Member

Thanks!

@AaronFeickert AaronFeickert deleted the fix-audio-tooltips branch December 13, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Deafen audio" hover text doesn't reflect state
2 participants