Skip to content

Update Jinja2 to v0.0.2 #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update Jinja2 to v0.0.2 #1373

wants to merge 5 commits into from
+2 −2

Conversation

@suraw00t
Copy link

@suraw00t suraw00t commented Sep 6, 2024 •
edited
Loading

Add support a new .j2 path suffix and bump version for Jinja2

@cla-bot
Copy link

cla-bot bot commented Sep 6, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @suraw00t on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@suraw00t
Copy link
Author

suraw00t commented Sep 6, 2024

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Sep 6, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @suraw00t on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot
Copy link

cla-bot bot commented Sep 6, 2024

The cla-bot has been summoned, and re-checked this pull request!

@suraw00t
Copy link
Author

suraw00t commented Sep 7, 2024

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Sep 7, 2024

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Sep 7, 2024
@suraw00t suraw00t changed the title Add support a new .j2 path suffix and bump version for Jinja2 Update bump version for Jinja2 Sep 9, 2024
@maxdeviant maxdeviant changed the title Update bump version for Jinja2 Update Jinja2 to v0.0.2 Sep 9, 2024
maxdeviant
maxdeviant requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update the version to 0.0.2 in the extension.toml here:

ArcherHume/jinja2-support@c732da5...ef7f82d#diff-21e42dd2276e594017780607a13f07b058d020447a73c11f032c77823a8ed493R3

@suraw00t suraw00t closed this Sep 10, 2024
@suraw00t
Copy link
Author

Thanks 😄

@SecT0uch
Copy link

@suraw00t Did you close the PR on purpose ?

I would like to use changes from 0.0.2

@suraw00t
Copy link
Author

I forgot to update this change since that cla-bot check failed, I will reopen this PR.

@suraw00t suraw00t reopened this Oct 10, 2025
@suraw00t suraw00t requested a review from maxdeviant October 10, 2025 13:26
maxdeviant
maxdeviant requested changes Oct 26, 2025
View reviewed changes
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suraw00t Could you please add a license to your extension repository?

https://zed.dev/docs/extensions/developing-extensions#extension-license-requirements

@maxdeviant maxdeviant added the missing-license The extension is missing a compatible license label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxdeviant maxdeviant maxdeviant requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

cla-signed missing-license The extension is missing a compatible license

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suraw00t @SecT0uch @maxdeviant