Move Poseidon primitive into halo2_poseidon
#831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
poseidon-primitive
branch
2 times, most recently
from
0192b97 to
0d88368
Compare
nuttycom
approved these changes
Dec 16, 2024
Comment on lines
+174
to
+175
| self.mode = Absorbing::init_empty(); | ||
| self.mode.absorb(value).expect("state is not full"); |
There was a problem hiding this comment.
Doesn't this suggest that 0d88368#diff-76142ee2fee95e1ba7ebdff8392dfb7442517333aaf489d5cf92d6dcebee37a4R190-R194 should be public?
| /// Attempts to absorb a value into the sponge state. | ||
| /// | ||
| /// Returns the value if it was not absorbed because the sponge is full. | ||
| pub fn absorb(&mut self, value: F) -> Result<(), F> { |
There was a problem hiding this comment.
Is Result the right type to return here? Or should it be a bespoke enum? It looks to me like the kind of thing that I would ordinarily use Either for rather than Result, but a bespoke enum might be better.
This is to make the next commit correctly detect a move.
str4d
force-pushed
the
poseidon-primitive
branch
from
0d88368 to
5893850
Compare
|
Rebased on |
nuttycom
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.