feat: replace Python markitdown with markitdown-typescript - #88
Open
zcaceres wants to merge 3 commits into
Open
Conversation
Swap the Python markitdown subprocess dependency for the native TypeScript library (markitdown-typescript), eliminating the need for a Python runtime, virtual environment, and setup scripts. - Replace _markitdown() subprocess call with createMarkItDown().convert() - URL conversions pass URLs directly to library (no temp file dance) - Remove Python infrastructure: preinstall.js, setup.sh, setup.bat, pyproject.toml, .python-version, uv.lock - Simplify Dockerfile (no Python layer) - Remove unused utils (isUnconvertedHtml, inferExtensionFromUrl) - Replace placeholder test fixtures with real document files - Add regression tests: output quality, URL conversions, SSRF protection, error wrapping, HTML passthrough guard NOTE: markitdown-typescript is currently linked as a local file dependency — must be published to npm before merging.
- Remove unused safeFetch() method (markitdown-ts handles URLs internally) - Remove projectRoot ghost parameter from toMarkdown(), server schema, and tests - Update README: pnpm → bun, remove Python/uv references and UV_PATH config - Remove .venv from .gitignore
Use HTML fixtures with streamInfo URL hints to exercise the YouTube and Bing SERP-specific converters without network calls. Tests verify metadata extraction, search result parsing, Bing redirect URL decoding, and SVG data URI stripping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markitdownsubprocess dependency with the native TypeScript library (markitdown-typescript), eliminating the Python runtime requirementpreinstall.js,setup.sh,setup.bat,pyproject.toml,.python-version,uv.lock, and Python venv from Dockerfilemarkitdown-typescriptis currently a local file dependency (file:../markitdown-ts). Must be published to npm and switched to a version range before merging.Test plan
markitdown-typescriptto npm and update dependency before merge