Map: Predefined views for landmarks #696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dlurak
commented
Oct 18, 2024
| return `https://osmapp.org${end}`; | ||
| } | ||
| // TODO: Find the *right* url also for preview deployments | ||
| return `http://localhost:3000${end}`; |
There was a problem hiding this comment.
This currently blocks preview deployments but i don't know how to get the correct url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some landmarks now have predefined views. These views include pitch, bearing and zoom. For towers the bearing might be irrelevant so any of these properties is optional.
When the user opens a link to a landmark with a defined view and without a position hash the view is automatically applied, when searching for a item the view is also applied.
When the user clicks on a landmark nothing happens by default but a button is shown to go to the recommended view.
Example links
Screenshots
Problems