Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploration - fetch og:image for feature #132

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Exploration - fetch og:image for feature #132

wants to merge 1 commit into from

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Feb 18, 2023

Currently works only for serverside rendering of a feature. For browser it would need a proxy to avoid CORS.

Eg. here:

TODO:

  • how to set cookie in next response

Currently works only for serverside rendering of a feature. For browser it would need a proxy to avoid CORS.
@vercel
Copy link

vercel bot commented Feb 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
osmapp ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 18, 2023 at 10:43AM (UTC)

@Dlurak
Copy link
Collaborator

Dlurak commented Sep 20, 2024

This pr is old but I still think the feature would be a reliable source for images.
Maybe we should wait for my pr #539 and then add this as another source?
If you don't want to do it yourself I can also do it, including the proxy just let me know.

@Dlurak
Copy link
Collaborator

Dlurak commented Sep 20, 2024

And also I think it would be way faster if we stream the html response instead of awaiting the entire page as the meta tags are usually at the top and the entire page can be huge.

@zbycz
Copy link
Owner Author

zbycz commented Sep 21, 2024

Yes, you may take it. I think I will review #539 today.

This PR was waiting until we had the FeatureImages slider.

Also streaming/getting only first x bytes sounds good. This was only exploration.

btw, once you are implementing this, the proxy should return only the meta tags or the og:image url only, not the whole page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants