Skip to content

Implement Store.move #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brokkoli71
Copy link
Member

This PR implements a move method for stores. This only affects stores that contain a path. afaics thats:

  • LocalStore
  • FsspecStore
  • ZipStore

Am I missing one?

Maybe, this PR could also implement moving the content from one store to a new one of a different type e.g.

store = LocalStore(root="path")
store.move(dest=MemoryStore())

Feedback/thoughts welcome

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 25, 2025
@brokkoli71 brokkoli71 marked this pull request as draft April 25, 2025 14:44
@paraseba
Copy link
Contributor

I don't think this can be meaningfully implemented by any other Stores. Maybe it shouldn't be a method in the abstract class, but purely a concrete implementation for the Stores that can do it efficiently.

In a real world scenario, moving a cloud Store could take days, cost thousands of dollars and fail. People wouldn't want to run this kind of operation in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Implement store methods for erase and rename operations
2 participants