Skip to content

create a module for group metadata #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/3019.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Move ``GroupMetadata`` and related classes a group-specific module inside the ``metadata`` module.
8 changes: 6 additions & 2 deletions src/zarr/api/asynchronous.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,15 @@
)
from zarr.core.group import (
AsyncGroup,
create_hierarchy,
)
from zarr.core.metadata import (
ArrayMetadataDict,
ArrayV2Metadata,
ArrayV3Metadata,
ConsolidatedMetadata,
GroupMetadata,
create_hierarchy,
)
from zarr.core.metadata import ArrayMetadataDict, ArrayV2Metadata, ArrayV3Metadata
from zarr.core.metadata.v2 import _default_compressor, _default_filters
from zarr.errors import NodeTypeValidationError
from zarr.storage._common import make_store_path
Expand Down
3 changes: 2 additions & 1 deletion src/zarr/core/array.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
ArrayV2MetadataDict,
ArrayV3Metadata,
ArrayV3MetadataDict,
GroupMetadata,
T_ArrayMetadata,
)
from zarr.core.metadata.v2 import (
Expand Down Expand Up @@ -3761,7 +3762,7 @@ async def chunks_initialized(
def _build_parents(
node: AsyncArray[ArrayV2Metadata] | AsyncArray[ArrayV3Metadata] | AsyncGroup,
) -> list[AsyncGroup]:
from zarr.core.group import AsyncGroup, GroupMetadata
from zarr.core.group import AsyncGroup

store = node.store_path.store
path = node.store_path.path
Expand Down
Loading