Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open zip store from path with zip suffix #2856

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Open zip store from path with zip suffix #2856

wants to merge 6 commits into from

Conversation

aulemahal
Copy link

@aulemahal aulemahal commented Feb 21, 2025 •
edited
Loading

  • Opening a string or Path path is redirected to ZipStore if the path has a .zip suffix.

Fixes #2831

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

The added test is not as elegant as the other from the suite. Is there a way to get an existing zipped zarr dataset within the test suite ? Should I create another fixture instead of writing my own zarr in the test ?

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 21, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Mar 3, 2025
@aulemahal
Copy link
Author

I did not add anything in the user-guide/*.rst files as I didn't feel it was necessary. The docstring of open( already makes mention of this feature.

dstansby
dstansby requested changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor comment, but I think worth fixing 👍

@nhz2 nhz2 mentioned this pull request Mar 5, 2025
Draft
@aulemahal aulemahal requested a review from dstansby April 7, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby Awaiting requested review from dstansby

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't conveniently open zip store from path with zarr v3
2 participants
@aulemahal @dstansby