Array creation with strings for filters, serializer, compressors #2839
+86
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
brokkoli71
commented
Feb 18, 2025
| _compressor = parse_compressor(compressor) | ||
|
|
||
| if filters is None: | ||
| _filters = None | ||
| elif filters == "auto": | ||
| _filters = default_filters | ||
| else: | ||
| if isinstance(filters, Iterable): |
There was a problem hiding this comment.
This is also checked in parse_filters, so I removed it
brokkoli71
commented
Feb 18, 2025
| @@ -4264,24 +4264,13 @@ def _parse_chunk_encoding_v2( | |||
| elif isinstance(compressor, tuple | list) and len(compressor) == 1: | |||
| _compressor = parse_compressor(compressor[0]) | |||
| else: | |||
| if isinstance(compressor, Iterable) and not isinstance(compressor, dict): | |||
normanrz
reviewed
Apr 7, 2025
| @@ -1124,6 +1149,30 @@ async def test_v2_chunk_encoding( | |||
| assert arr.compressors == compressor_expected | |||
| assert arr.filters == filters_expected | |||
|
|
|||
| @staticmethod | |||
There was a problem hiding this comment.
Can you please add another test, where a codec would need mandatory configuration params to fail with just a string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
docs/user-guide/*.rstchanges/