Remove ZARR_DEFAULT_FILL_VALUE lookup
#812
Open
+39
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
- Coverage 87.75% 87.72% -0.03%
==========================================
Files 35 35
Lines 1886 1882 -4
==========================================
- Hits 1655 1651 -4
Misses 231 231
🚀 New features to boost your workflow:
|
|
Doh! Wanna add a release note documenting the bugfix? Also possibly a regression test that uses unsigned ints... |
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
norlandrhagen
temporarily deployed
to
test-release
GitHub Actions
Inactive
|
Added! I think the mypy and rtd errors are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #811.
In the zarr-parser I used the
ZARR_DEFAULT_FILL_VALUElookup dict, but thefill_valuewas never used / reassigned in theArrayV3Metadata. I think it's only purpose was causing bugs like #811.