Refactor kerchunk readers to use manifest store #547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
had a problem deploying
to
test-release
GitHub Actions
Failure
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
commented
Apr 12, 2025
Comment on lines
+120
to
+121
| # TODO what should the obstore store be? | ||
| return ManifestStore(group=manifestgroup) |
There was a problem hiding this comment.
@maxrjones I think I need default_object_store() in order to continue with this PR.
EDIT: See #549
This was referenced Apr 14, 2025
maxrjones
reviewed
Apr 17, 2025
for more information, see https://pre-commit.ci
…s://github.com/TomNicholas/VirtualiZarr into refactor-kerchunk-readers-to-use-ManifestStore
|
Superceded by #601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to refactor all the kerchunk-based readers to use
ManifestStore, but to do that this PR first adds aManifestStore.from_kerchunk_refs()method.docs/releases.rstapi.rst