Chunk aligned indexing using zarr-python v3 #499
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es from zarr-python v3 internals
for more information, see https://pre-commit.ci
TomNicholas
commented
Mar 22, 2025
There was a problem hiding this comment.
Remember not to commit changes to this file - it was just to get tests running working locally and is unrelated to this PR
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
for more information, see https://pre-commit.ci
TomNicholas
commented
Mar 22, 2025
Comment on lines
+43
to
+44
| if indexer.drop_axes: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
This never triggers, and I don't know why. Either a bug in zarr.core.indexing or I don't understand this part of zarr.core.indexing (more likely).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #183, but this PR takes advantage of indexing internals from zarr-python v3
docs/releases.rstapi.rst