Skip to content

Update translators.kerchunk in preparation for TIFF reader fix #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

elyall
Copy link

@elyall elyall commented Nov 14, 2024

  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

Two small changes:

  1. virtual_vars_from_kerchunk_refs now takes in arr_refs instead of refs. This allows a single array to be wrapped.
  2. find_groups is spun out. TIFFs can store a Dataset or a DataArray. So I was imagining this could be used for something like:
refs = kerchunk.tiff_to_zarr(urlpath)
is_dataarray = find_groups({"refs": refs}) == []

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (support/v1@3bf3f78). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             support/v1     #297   +/-   ##
=============================================
  Coverage              ?   81.86%           
=============================================
  Files                 ?       41           
  Lines                 ?     2553           
  Branches              ?        0           
=============================================
  Hits                  ?     2090           
  Misses                ?      463           
  Partials              ?        0           
Files with missing lines Coverage Δ
virtualizarr/translators/kerchunk.py 96.42% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants