Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental chunky edit strategy #18

Merged
merged 1 commit into from
Jan 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .changeset/tasty-readers-knock.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
'refactor-bot': patch
---

feat: introducing experimental chunky edit strategy

This strategy allows the LLM to perform edits via find-replace operations which
reduce the total number of completion tokens. The completion tokens are
typically priced at twice the cost of prompt tokens. In addition to the
reduction of the price this strategy also significantly improves the performance
of the refactoring.

Here are benchmark results for the `chunky-edit` strategy:

```sh
METRIC │ A │ B │ DIFF
────────────────────────┼───────────┼───────────┼──────────
numberOfRuns │ 9.00 │ 10.00 │
score │ 0.83 │ 1.00 │ +17.28%
acceptedRatio │ 0.81 │ 1.00 │ +18.52%
totalTokens │ 44688.67 │ 50365.90 │ +12.70%
totalPromptTokens │ 40015.44 │ 48283.30 │ +20.66%
totalCompletionTokens │ 4673.22 │ 2082.60 │ -55.44%
wastedTokensRatio │ 0.09 │ 0.00 │ -9.49%
durationMs │ 286141.39 │ 171294.32 │ -40.14%
```

While it does seem to improve the score, this should just be considered as
variance introduce by the randomness of the LLM. The main outcome of this
strategy is the reduction of the number of completion tokens and the improvement
of the performance.

There might be some other side effects, probably depending on the type of the
refactor. So, this strategy is still experimental and must be selectively
opted-in via "--experiment-chunky-edit-strategy" cli option.
19 changes: 19 additions & 0 deletions .refactor-bot/benchmarks/chunky-edit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
refactorConfig:
name: test-likely-success
ref: 8f1a3da55caeee3df75853042e57978c45513f18
budgetCents: 100
model: gpt-4-1106-preview
objective:
Replace all usages of `readFile` from `fs/promises` module with
`readFileSync` from `fs` module in
`packages/refactor-bot/src/refactor/planTasks.ts`,
`packages/refactor-bot/src/refactor/loadRefactors.ts` and
`packages/refactor-bot/src/refactor/discoverDependencies.ts`.

numberOfRuns: 10

variants:
- name: 'A'
- name: 'B'
args:
- --experiment-chunky-edit-strategy
2 changes: 1 addition & 1 deletion packages/refactor-bot/src/prompt/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const promptCommand: CommandModule<
yargs
.option('model', {
choices: modelsSchema.options,
default: 'gpt-4-1106-preview' as const,
default: 'gpt-4-turbo-preview' as const,
})
.option('watch', {
type: 'boolean',
Expand Down
Loading
Loading