Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply --no-color to dev and console logging option, remove console-no-color #3312

Merged
merged 3 commits into from
Dec 10, 2024
Merged

feat: apply --no-color to dev and console logging option, remove console-no-color #3312

merged 3 commits into from
Dec 10, 2024

Conversation

AustinAbro321
Copy link
Contributor

Related Issue

Fixes #3306

Checklist before merging

@AustinAbro321
logger no color
a5a55ca 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners December 10, 2024 17:46
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a49ea28
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67588625c5ab020008b811f8

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/root.go 0.00% 7 Missing ⚠️
src/pkg/logger/logger.go 50.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/logger/logger.go 53.78% <50.00%> (-3.98%) ⬇️
src/cmd/root.go 0.00% <0.00%> (ø)

@AustinAbro321
make docs and schema
68562f0 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
bool type declaration
a49ea28 
Signed-off-by: Austin Abro <[email protected]>
mkcp
mkcp approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 66deda7 Dec 10, 2024
38 checks passed
@AustinAbro321 AustinAbro321 deleted the apply-no-color-to-logger-options branch December 10, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcp mkcp mkcp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove console-no-color option on --log-format and make console and dev respect the no-color flag
2 participants
@AustinAbro321 @mkcp