Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logger from pkg/logger to internal/logger #3213

Closed
Tracked by #3210
mkcp opened this issue Nov 7, 2024 · 1 comment
Closed
Tracked by #3210

Move logger from pkg/logger to internal/logger #3213

mkcp opened this issue Nov 7, 2024 · 1 comment
Labels
enhancement ✨ New feature or request

Comments

@mkcp
Copy link
Contributor

mkcp commented Nov 7, 2024

Is your feature request related to a problem? Please describe.

Logger is intended as a small wrapper around log/slog that bakes in input validation, ctx setters / getters, some app-specific default configuration.

Describe the behavior you'd like

Logger is not intended to provide a stable API, so to avoid any downstream conflicts we're going to move it to internal. Consumers are welcome to copy and paste any of the patterns within if they find it useful, and inquire with the Zarf team to learn about why we chose to build it the way we have.

Additional context

Logger: https://github.com/zarf-dev/zarf/tree/main/src/pkg/logger

Component of: #3210

@mkcp mkcp added the enhancement ✨ New feature or request label Nov 7, 2024
@mkcp mkcp mentioned this issue Nov 7, 2024
4 tasks
@mkcp
Copy link
Contributor Author

mkcp commented Nov 8, 2024

Discussed this some more and closing this out. We'll keep logger in pkg to avoid creating any downstream issues for folks utilizing Zarf as a library.

@mkcp mkcp closed this as completed Nov 8, 2024
@mkcp mkcp closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant