Skip to content

Improve hamburger mobile touch target and add aria-controls #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve hamburger mobile touch target and add aria-controls #3255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4aa800
fix(hamburger): increase hit area and add aria-controls
ritorhymes Sep 18, 2025
f9d5f0d
chore(styles): remove empty SCSS selector flagged by linter
ritorhymes Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/layouts/partials/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="hamburger-icon">
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M0 0h24v24H0z" fill="none"/><path d="M3 18h18v-2H3v2zm0-5h18v-2H3v2zm0-7v2h18V6H3z"/></svg>
</div>
<input class="hamburger-click" aria-label="site menu" type="checkbox" />
<input class="hamburger-click" aria-label="toggle site menu" aria-controls="primary-menu" type="checkbox" />
<ul id="primary-menu" class="flex">
{{ $currentPage := . }}
{{ range .Site.Menus.nav }}
Expand Down
11 changes: 4 additions & 7 deletions src/css/_navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,18 +140,15 @@
}
}

.site-header nav .sub-menu {
a {
}
}

.hamburger-click {
cursor: pointer;
height: 45px;
width: 45px;
opacity: 0.0;
z-index: 2;
position: absolute;
top: 36px;
right: 40px;
top: 20px;
right: 24px;
}

@media screen and (max-width: 825px) {
Expand Down