Fix: Ensure database transaction rollback on migration failure - #2
Open
iyeanur6-cyber wants to merge 2 commits into
Open
Fix: Ensure database transaction rollback on migration failure#2iyeanur6-cyber wants to merge 2 commits into
iyeanur6-cyber wants to merge 2 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Overview
This PR implements a safe transactional rollback mechanism for database migrations. It ensures that if any step within a migration execution fails, the active transaction is explicitly rolled back to prevent leaving the database in a dirty or partially migrated state.
🛠️ Changes Made
Implemented db.BeginTx() for atomic migration execution.
Added a deferred rollback block (defer tx.Rollback()) to handle cleanup safely and log non-sql.ErrTxDone errors.
Ensured transaction locks and database connections are properly released on failure.
Guaranteed that failed migrations are not marked as applied in the database metadata.
🧪 Testing & Verification
Tested transaction behavior on migration failures to ensure zero schema side effects.
Verified that connection leaks do not occur after multiple consecutive migration failures.