fix: improve error messages for public key fetch failures#382
Open
gaffar273 wants to merge 1 commit intozama-ai:mainfrom
Open
fix: improve error messages for public key fetch failures#382gaffar273 wants to merge 1 commit intozama-ai:mainfrom
gaffar273 wants to merge 1 commit intozama-ai:mainfrom
Conversation
- Replace misleading 'Impossible to fetch public key: wrong relayer url.' message - Use context-specific messages for different error scenarios - network.ts: 'Failed to fetch or deserialize public key' - RelayerV2PublicKey.ts: 'Failed to initialize public key from relayer response' - TFHECrs.ts: 'Failed to fetch or deserialize CRS from URL' - TFHEPublicKey.ts: 'Failed to fetch or deserialize public key from URL' - Use TFHEPublicKeyError instead of generic Error in TFHEPublicKey.ts - Preserve original error in cause for debugging
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @gaffar273 on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace misleading 'Impossible to fetch public key: wrong relayer url.' message
Use context-specific messages for different error scenarios
network.ts: 'Failed to fetch or deserialize public key'
RelayerV2PublicKey.ts: 'Failed to initialize public key from relayer response'
TFHECrs.ts: 'Failed to fetch or deserialize CRS from URL'
TFHEPublicKey.ts: 'Failed to fetch or deserialize public key from URL'
Use TFHEPublicKeyError instead of generic Error in TFHEPublicKey.ts
Preserve original error in cause for debugging