-
Notifications
You must be signed in to change notification settings - Fork 0
Pull requests
###Updates After creating of the pull request a code reviewer could comment on this pull request. This will automatically notify the person who has submitted it. He could go that branch, make changes and push them to the repo. Once it has been done the pull request will automatically encounter these changes. Pull request points to the HEAD of the branch instead of a particular commit. After merging a branch a pull request will be automatically closed.
###Key considerations while merging a pull request
- interactively rebase to simplify history?
Never squash an entire branch. Instead squash commits that are no longer necessary.
- rebase to create linear history?
According to your preferences.
- merge by fast-forward or recursive strategy?
Recursive merge is generally better than fast-forward, since under fast-forward merge it is hard to trace what commit refers to what feature or branch. Moreover, after recursive merging you could revert the whole feature reverting just the merge commit.
###Comments There are three types of comments on pull requests
- on pull request itself;
- on particular commit;
- on a particular branch.